Add intrinsic-test alias and set sample rate by xonx4l · Pull Request #159898 · rust-lang/rust

xonx4l · 2026-07-25T12:45:26Z

This PR adds intrinsic-test alias and set sample rate.

It sets sample percentage to 100% .

rustbot · 2026-07-25T12:45:32Z

Kobzol is not on the review rotation at the moment.
They may take a while to respond.

Kobzol · 2026-07-25T19:30:19Z

I just realized that we didn't update the x86_64-gnu CI job when making the test be executed by default. It should no longer run intrinsic-test manually, but on the other hand it should set the new sde bootstrap config option in RUST_CONFIGURE_ARGS. We are now no longer running the intrinsic test on x86 :) Let's do that before landing this PR, in another PR, please. Thank you!

In the meantime, let's check how this affects the duration on aarch64:

@bors try jobs=aarch64-gnu

Add intrinsic-test alias and set sample rate try-job: aarch64-gnu

rust-bors · 2026-07-25T21:37:28Z

☀️ Try build successful (CI)
Build commit: ba43932 (ba4393208e7af8ec5db1d0c013b8e9cc077cfc5d)
Base parent: da86f4d (da86f4d0726be475afbbffe40cb2f65741c51ad3)

Kobzol · 2026-07-26T07:07:40Z

Seems like on aarch64-gnu, the duration went from ~20s to ~40s? That seems entirely fine, of course.

xonx4l · 2026-07-26T11:33:28Z

I just realized that we didn't update the x86_64-gnu CI job when making the test be executed by default. It should no longer run intrinsic-test manually, but on the other hand it should set the new sde bootstrap config option in RUST_CONFIGURE_ARGS. We are now no longer running the intrinsic test on x86 :) Let's do that before landing this PR, in another PR, please. Thank you!

In the meantime, let's check how this affects the duration on aarch64:

@bors try jobs=aarch64-gnu

Yeah we forgot about x86_64-gnu CI job . Will make the change as suggested . Thank you!

xonx4l · 2026-07-29T09:58:07Z

@Kobzol I think it's ready to get merged now :). Thank you!

Kobzol · 2026-07-29T13:29:11Z

Thanks! You can r=me once PR CI is green :)

@bors delegate

rust-bors · 2026-07-29T13:29:14Z

✌️ @xonx4l, you can now approve this pull request!

If @Kobzol told you to "r=me" after making some further change, then please make that change and post @bors r=Kobzol.

View changes since this delegation.

xonx4l · 2026-07-29T16:47:39Z

@bors r=Kobzol

rust-bors · 2026-07-29T16:47:42Z

📌 Commit dcb0002 has been approved by Kobzol

It is now in the queue for this repository.

@Kobzol

… r=Kobzol Add intrinsic-test alias and set sample rate This PR adds intrinsic-test alias and set sample rate. It sets sample percentage to 100% . r? @Kobzol

Rollup of 17 pull requests Successful merges: - #159014 ([rustdoc] Do not take `doc(cfg())` into account when filtering doctests) - #159130 (a bit optimize four-digit chunks in integer formatting) - #159592 (core: implement bounded random sampling) - #159898 (Add intrinsic-test alias and set sample rate) - #158247 (hermit/fs: Return `unsupported()` instead of `from_raw_os_error(22)`) - #158649 (Hermit: fix `readdir()` ) - #159049 (Avoid ICE in From/TryFrom cast suggestion when encountering HRTBs) - #160053 (test: add test suite for the 85681 issue) - #160087 (Add regression test for nested associated-type projection ICE) - #160090 (rustc_resolve: Further reduce mutability in resolver) - #160099 (Resolver: split module resolutions into local and external resolutions) - #160106 (Add suggestions for `must_implement_one_of`) - #160117 (Remove unnecessary format usage) - #160134 (Work around Wine bug 60084 by calling WSAStartup at most once) - #160142 (bootstrap: remove use-lld config alias) - #160148 (Rename `errors.rs` file to `diagnostics.rs` (15/N)) - #160151 (Mark a doctest as requiring unwinding)

@Kobzol

… r=Kobzol Add intrinsic-test alias and set sample rate This PR adds intrinsic-test alias and set sample rate. It sets sample percentage to 100% . r? @Kobzol

JonathanBrouwer · 2026-07-30T22:09:55Z

@bors p=6
Scheduling this before the rollup so it has time to run try jobs

@Kobzol

Add intrinsic-test alias and set sample rate This PR adds intrinsic-test alias and set sample rate. It sets sample percentage to 100% . r? @Kobzol

Zalathar · 2026-07-31T03:31:34Z

This current run is probably doomed, though it's a lot harder to tell now that bors refuses to show how long a job has been running.

@bors p=1
@bors yield

rust-bors · 2026-07-31T03:31:38Z

Auto build was cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/30589982083

The next pull request likely to be tested is #160238.

@Kobzol

Add intrinsic-test alias and set sample rate This PR adds intrinsic-test alias and set sample rate. It sets sample percentage to 100% . r? @Kobzol

rust-log-analyzer · 2026-07-31T04:18:54Z

The job aarch64-apple failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[RUSTC-TIMING] shlex test:false 0.279
   Compiling rustc-main v0.0.0 (/Users/runner/work/rust/rust/compiler/rustc)
error: linking with `cc` failed: exit status: 1
  |
  = note:  "cc" "/Users/runner/work/rust/rust/build/aarch64-apple-darwin/stage1-rustc/release/build/rustc-main/946e6a3afa0eeedd/out/rustcBBfRGh/symbols.o" "<2 object files omitted>" "/Users/runner/work/rust/rust/build/aarch64-apple-darwin/stage1-rustc/release/build/rustc_windows_rc/9f729b62316d91ea/out/librustc_windows_rc-9f729b62316d91ea.rlib" "/Users/runner/work/rust/rust/build/aarch64-apple-darwin/stage1-rustc/release/build/find-msvc-tools/114b21a2a2d12b7d/out/libfind_msvc_tools-114b21a2a2d12b7d.rlib" "<sysroot>/lib/rustlib/aarch64-apple-darwin/lib/{libstd-*,libpanic_unwind-*,libobject-*,libmemchr-*,libaddr2line-*,libgimli-*,libcfg_if-*,librustc_demangle-*,libstd_detect-*,libhashbrown-*,librustc_std_workspace_alloc-*,libminiz_oxide-*,libadler2-*,libunwind-*,liblibc-*,librustc_std_workspace_core-*,liballoc-*,libcore-*,libcompiler_builtins-*}.rlib" "-lSystem" "-lc" "-lm" "-arch" "arm64" "-mmacosx-version-min=11.0.0" "-o" "/Users/runner/work/rust/rust/build/aarch64-apple-darwin/stage1-rustc/release/build/rustc-main/946e6a3afa0eeedd/out/build_script_build" "-Wl,-dead_strip" "-nodefaultlibs"
  = note: some arguments are omitted. use `--verbose` to show all linker arguments
  = note: clang: error: unable to execute command: Segmentation fault: 11
          clang: error: linker command failed due to signal (use -v to see invocation)
          Apple clang version 17.0.0 (clang-1700.6.3.2)
          Target: arm64-apple-darwin24.6.0
          Thread model: posix
          InstalledDir: /Applications/Xcode_26.2.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
          clang: note: diagnostic msg: 
          ********************
          
          PLEASE ATTACH THE FOLLOWING FILES TO THE BUG REPORT:
          Linker snapshot containing input(s) and associated run script(s) are located at:
          clang: note: diagnostic msg: /var/folders/_5/zjnzxgh147qcg3bb5cg2wvqw0000gn/T/linker-crash-bddf41
          clang: note: diagnostic msg: 
          
          ********************
          

[RUSTC-TIMING] build_script_build test:false 2.092

rust-bors · 2026-07-31T04:19:16Z

💔 Test for ed50094 failed: CI. Failed job:

auto - aarch64-apple (web logs, enhanced plaintext logs)

Zalathar · 2026-07-31T04:35:44Z

@bors retry

@Kobzol

Add intrinsic-test alias and set sample rate This PR adds intrinsic-test alias and set sample rate. It sets sample percentage to 100% . r? @Kobzol

Kobzol · 2026-07-31T08:13:41Z

@bors yield

To give priority to the LLVM update PR.

rust-bors · 2026-07-31T08:13:45Z

Auto build was cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/30615226730

The next pull request likely to be tested is #158734.

JonathanBrouwer · 2026-07-31T09:59:17Z

@bors p=6 Scheduling

rust-bors · 2026-07-31T13:51:32Z

☀️ Test successful - CI
Approved by: Kobzol
Duration: 3h 48m 32s
Pushing fc0f51f to main...

github-actions · 2026-07-31T13:55:03Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 922325b (parent) -> fc0f51f (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard fc0f51f5ca44d4586b0e309181382608cd6a8441 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-riscv64-linux-gnu: 1h 1m -> 1h 32m (+50.3%)
x86_64-gnu-llvm-21-2: 1h 2m -> 1h 30m (+45.5%)
x86_64-gnu-gcc-core-tests: 11m 9s -> 7m 34s (-32.2%)
dist-aarch64-linux: 2h 51m -> 1h 58m (-30.8%)
dist-x86_64-solaris: 1h 18m -> 1h 42m (+30.4%)
x86_64-msvc-ext3: 1h 23m -> 1h 48m (+29.8%)
dist-ohos-x86_64: 1h 2m -> 1h 19m (+28.9%)
x86_64-gnu-gcc: 1h 9m -> 49m 24s (-28.7%)
x86_64-gnu-llvm-22-3: 1h 22m -> 1h 45m (+28.5%)
x86_64-gnu-llvm-21-1: 53m 52s -> 38m 50s (-27.9%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-07-31T14:50:53Z

Finished benchmarking commit (fc0f51f): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.1%	[0.1%, 0.2%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (secondary 1.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.8%	[0.9%, 6.1%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.2%	[-2.4%, -0.4%]	3
All ❌✅ (primary)	-	-	0

Cycles

Results (primary 0.3%, secondary -2.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.2%	[0.6%, 3.3%]	6
Regressions ❌ (secondary)	1.0%	[0.4%, 3.1%]	11
Improvements ✅ (primary)	-1.0%	[-2.4%, -0.4%]	4
Improvements ✅ (secondary)	-5.0%	[-10.6%, -0.5%]	11
All ❌✅ (primary)	0.3%	[-2.4%, 3.3%]	10

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 490.333s -> 491.246s (0.19%)
Artifact size: 392.58 MiB -> 390.66 MiB (-0.49%)

Add intrinsic-test alias and set test sample rate

551f8d4

rustbot assigned Kobzol Jul 25, 2026

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jul 25, 2026

This comment has been minimized.

Sign in to view

skip intrinsic-test alias on LLVM 21

9894451

rustbot added A-CI Area: Our Github Actions CI T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jul 25, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Jul 25, 2026

Auto merge of #159898 - xonx4l:intrinsic-test-sample-rate, r=<try>

ba43932

Add intrinsic-test alias and set sample rate try-job: aarch64-gnu

Kobzol reviewed Jul 29, 2026

View reviewed changes

Comment thread src/bootstrap/src/core/build_steps/test.rs Outdated

Comment thread src/ci/docker/scripts/stage_2_test_set1.sh Outdated

Comment thread src/ci/docker/scripts/stage_2_test_set2.sh Outdated

remove intrinsic-test path

dcb0002

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 29, 2026

jhpratt mentioned this pull request Jul 29, 2026

Rollup of 17 pull requests #160168

Closed

jhpratt mentioned this pull request Jul 29, 2026

Rollup of 18 pull requests #160174

Closed

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 30, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 31, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 31, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 31, 2026

rust-bors Bot merged commit fc0f51f into rust-lang:main Jul 31, 2026
15 checks passed

rustbot added this to the 1.99.0 milestone Jul 31, 2026

rust-bors Bot mentioned this pull request Jul 31, 2026

bootstrap: Don't pass Kind to some places that don't need it #160191

Open

Uh oh!

Uh oh!

Conversation

xonx4l commented Jul 25, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 25, 2026

Uh oh!

This comment has been minimized.

Kobzol commented Jul 25, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jul 25, 2026

Uh oh!

Kobzol commented Jul 26, 2026

Uh oh!

xonx4l commented Jul 26, 2026

Uh oh!

xonx4l commented Jul 29, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Kobzol commented Jul 29, 2026

Uh oh!

rust-bors Bot commented Jul 29, 2026

Uh oh!

xonx4l commented Jul 29, 2026

Uh oh!

rust-bors Bot commented Jul 29, 2026

Uh oh!

JonathanBrouwer commented Jul 30, 2026

Uh oh!

This comment has been minimized.

Zalathar commented Jul 31, 2026

Uh oh!

rust-bors Bot commented Jul 31, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Jul 31, 2026

Uh oh!

rust-bors Bot commented Jul 31, 2026

Uh oh!

Zalathar commented Jul 31, 2026

Uh oh!

This comment has been minimized.

Kobzol commented Jul 31, 2026

Uh oh!

rust-bors Bot commented Jul 31, 2026

Uh oh!

JonathanBrouwer commented Jul 31, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jul 31, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jul 31, 2026

Test differences

Job duration changes

Uh oh!

rust-timer commented Jul 31, 2026

Overall result: ❌✅ regressions and improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

xonx4l commented Jul 25, 2026 •

edited by rustbot

Loading